Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError upon joining world due to assert currentConfigurationAddon != null #3330

Closed
Moulberry opened this issue Sep 23, 2023 · 1 comment · Fixed by #3331
Closed
Assignees
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.

Comments

@Moulberry
Copy link

Current Behavior

Running the game with -enableassertions crashes upon joining world

Analysis (mojmap)

ClientNetworkingImpl#setClientPlayAddon has an assertion that checks if currentConfigurationAddon is null
ClientNetworkingImpl#setClientPlayAddon is called when a ClientPacketListener is initialized
currentConfigurationAddon is set to null when Connection#setListener is called

ClientConfigurationPacketListenerImpl contains this code:
this.connection.setListener(new ClientPacketListener(...))
The ctor is invoked before setListener, causing the assertion to fail.

Steps to reproduce

  1. Add -enableassertions JVM flag
  2. Join a world

Environment

Minecraft 1.20.2
Fabric Loader 0.14.22
Fabric API 0.89.1

@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Sep 23, 2023
@modmuss50 modmuss50 self-assigned this Sep 23, 2023
@modmuss50
Copy link
Member

Thanks I can reproduce this. I wrongly assumed that we had asserations enabled in Fabric APIs dev env!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants