Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jukeboxes do not respect transactions #3680

Closed
TropheusJ opened this issue Mar 31, 2024 · 2 comments
Closed

Jukeboxes do not respect transactions #3680

TropheusJ opened this issue Mar 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@TropheusJ
Copy link
Contributor

using FAPI 0.92.0 on 1.20.1
code:

try (Transaction t = Transaction.openOuter()) {
    long inserted = inv.insert(ItemVariant.of(item), item.getCount(), t);
    t.abort();
}

before insertion: contains empty stack
image
after insert: contains record
image
after aborting, this does not get reverted.

@deirn
Copy link
Member

deirn commented Mar 31, 2024

#3517 fixes this issue in 1.20.4.

@Syst3ms
Copy link
Contributor

Syst3ms commented Mar 31, 2024

Shouldn't be too hard to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants