Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model offset is ignored by Indigo in non-terrain block rendering #3798

Closed
PepperCode1 opened this issue May 24, 2024 · 4 comments · Fixed by #3799 or comp500/Indium#295
Closed

Model offset is ignored by Indigo in non-terrain block rendering #3798

PepperCode1 opened this issue May 24, 2024 · 4 comments · Fixed by #3799 or comp500/Indium#295
Labels
bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api priority:high High priority PRs that need review and work now. Review these first.

Comments

@PepperCode1
Copy link
Member

This is an extremely old bug. I cannot identify if it was present in the original FRAPI/Indigo changes since I am not familiar with 1.15 rendering code, but I am quite sure it affects all versions 1.16 and newer, at least.

I plan to submit a pull request soon to fix this.

@PepperCode1 PepperCode1 added bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api priority:high High priority PRs that need review and work now. Review these first. labels May 24, 2024
@PepperCode1
Copy link
Member Author

It looks like model offsets for terrain rendering were also broken at some point but then fixed by this pull request. I assume offsets for non-terrain rendering have been broken since then as well, but no one noticed until now.

@peow
Copy link

peow commented Jun 25, 2024

this problem doesn't seem to have been solved yet
these 2 Pull Requests (#3799, comp500/Indium#295) arose due to a report of an incompatibility report between the A Good Place mod and Continuity (PepperCode1/Continuity#420), where the A Good Place mod adds animations when placing blocks, but when using any Connected Textures resourcepack the animations present a problem, because the block appears in place before the animation is finished.

Continuity.mp4

this problem only happens when Sodium and Indium are also present, in the video below im not using these mods

Without.Sodium.And.Indium.mp4

I've updated all the mods where the fix has already been implemented (Indium and Fabric API)

Mods links -
https://modrinth.com/mod/a-good-place
https://modrinth.com/mod/continuity
Fabric 1.20.1
Fabric Loader 0.15.11

@PepperCode1
Copy link
Member Author

This issue as described by the title and description is definitely 100% fixed, so it does not make sense to discuss unrelated issues here. Use the issue trackers for those mods to report remaining incompatibilities.

@peow
Copy link

peow commented Jun 26, 2024

ok, sorry
i only commented here because you said

Use FabricMC/fabric#3798 to track this issue since it's not a Continuity issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
2 participants