You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, PersistentState is not safe to use because if a crash/unexpected power loss happens and there's a large PersistentState that takes a large amount of time to write to disk, it could end up only being partially written and then fail to deserialize on startup.
As discussed if we make this change it should only apply to mods, and not effect the vanilla states. How we actually determine this is not super clear to me though.
Currently,
PersistentState
is not safe to use because if a crash/unexpected power loss happens and there's a largePersistentState
that takes a large amount of time to write to disk, it could end up only being partially written and then fail to deserialize on startup.This has been fixed in NeoForge via following PR: neoforged/NeoForge#1001
Refined Storage is currently having following
PersistentState
implementation as a stop-gap solution: https://github.com/refinedmods/refinedstorage2/blob/develop/refinedstorage-platform-common/src/main/java/com/refinedmods/refinedstorage/platform/common/support/AbstractSafeSavedData.javaThe text was updated successfully, but these errors were encountered: