Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelVariantProviders not called for every state if one state loaded by vanilla #571

Closed
TwilightFlower opened this issue Apr 12, 2020 · 3 comments
Closed

ModelVariantProviders not called for every state if one state loaded by vanilla #571

TwilightFlower opened this issue Apr 12, 2020 · 3 comments
Assignees
@Technici4n
Labels
bug Something isn't working

Comments

@TwilightFlower
Copy link

If a ModelVariantProvider chooses to not override one state and lets it load the vanilla way, it will not be called for any further states of that block. This is a rather niche bug but I'm having trouble finding a workaround.
@Prospector Prospector added the bug Something isn't working label Apr 14, 2020
@Jkmcameron
Copy link

Bump, still an issue. Not much else to be said other than what is said here. Not really niche at this point, seems more like an oversight

@Technici4n Technici4n self-assigned this Dec 19, 2022
@Technici4n Technici4n mentioned this issue Jun 25, 2023
Merged
@Technici4n
Copy link
Member

This will be addressed by the Model Loading API v1: #3145.

@Technici4n
Copy link
Member

Fixed in #3145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Technici4n Technici4n

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Prospector @Technici4n @TwilightFlower @Jkmcameron