Improve Indigo and FRAPI Test Mod #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use AO mode to make flat shade calculation consistent with shade applied by smooth lighting - Use face normal to calculate shade if necessary - Use normal shade even if no custom normals are set
- Add octagonal column to test irregular face lighting - Use obsidian sprite instead of missing sprite for frame mesh - Simplify and organize registration - Inline `simple` package
- Fix checkstyle - Give octagonal column a non-zero hardness
Technici4n
suggested changes
Jul 31, 2023
...v1/src/client/java/net/fabricmc/fabric/mixin/renderer/client/OverlayVertexConsumerMixin.java
Show resolved
Hide resolved
Technici4n
approved these changes
Aug 2, 2023
modmuss50
approved these changes
Aug 9, 2023
modmuss50
added
enhancement
modmuss50
pushed a commit
that referenced
this pull request
Aug 13, 2023
* Improve flat shade - Use AO mode to make flat shade calculation consistent with shade applied by smooth lighting - Use face normal to calculate shade if necessary - Use normal shade even if no custom normals are set * Improve FRAPI test mod - Add octagonal column to test irregular face lighting - Use obsidian sprite instead of missing sprite for frame mesh - Simplify and organize registration - Inline `simple` package * Fix crumbling on 45 degree faces - Fix checkstyle - Give octagonal column a non-zero hardness * Fix checkstyle * Improve PillarBakedModel to fully support custom block appearance * Explain OverlayVertexConsumer fix Signed-off-by: modmuss50 <[email protected]>
modmuss50
pushed a commit
that referenced
this pull request
Aug 13, 2023
* Improve flat shade - Use AO mode to make flat shade calculation consistent with shade applied by smooth lighting - Use face normal to calculate shade if necessary - Use normal shade even if no custom normals are set * Improve FRAPI test mod - Add octagonal column to test irregular face lighting - Use obsidian sprite instead of missing sprite for frame mesh - Simplify and organize registration - Inline `simple` package * Fix crumbling on 45 degree faces - Fix checkstyle - Give octagonal column a non-zero hardness * Fix checkstyle * Improve PillarBakedModel to fully support custom block appearance * Explain OverlayVertexConsumer fix
cocona20xx
pushed a commit
to cocona20xx/quilted-fabric-api
that referenced
this pull request
Oct 1, 2023
* Improve flat shade - Use AO mode to make flat shade calculation consistent with shade applied by smooth lighting - Use face normal to calculate shade if necessary - Use normal shade even if no custom normals are set * Improve FRAPI test mod - Add octagonal column to test irregular face lighting - Use obsidian sprite instead of missing sprite for frame mesh - Simplify and organize registration - Inline `simple` package * Fix crumbling on 45 degree faces - Fix checkstyle - Give octagonal column a non-zero hardness * Fix checkstyle * Improve PillarBakedModel to fully support custom block appearance * Explain OverlayVertexConsumer fix Signed-off-by: modmuss50 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve flat shade
Improve FRAPI test mod
PillarBakedModelto fully support custom block appearancesimplepackage