Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangedAttackMob.attack -> RangedAttackMob.shootAt #3602

Closed
Dev0Louis opened this issue Jul 4, 2023 · 2 comments
Closed

RangedAttackMob.attack -> RangedAttackMob.shootAt #3602

Dev0Louis opened this issue Jul 4, 2023 · 2 comments

Comments

@Dev0Louis
Copy link
Contributor

the .attack method is for attacking with a trident as you can see by the first line alone.
TridentEntity tridentEntity = new TridentEntity(this.getWorld(), (LivingEntity)this, new ItemStack(Items.TRIDENT));
I would suggest throwTrident.
@Dev0Louis
Copy link
Contributor Author

Oh I see now it is from the RangedAttackMob interface.
It may be worth a thought to change attack to shoot or shootAt

@Dev0Louis Dev0Louis changed the title DrownedEntity.attack is likely misleading. RangedAttackMob.attack -> RangedAttackMob.shoot Jul 4, 2023
@Dev0Louis
Copy link
Contributor Author

I created a Pull Request #3606

@Dev0Louis Dev0Louis changed the title RangedAttackMob.attack -> RangedAttackMob.shoot RangedAttackMob.attack -> RangedAttackMob.shootAt Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dev0Louis