Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #263 #272

Merged
merged 2 commits into from
May 12, 2020
Merged

Fixes #263 #272

merged 2 commits into from
May 12, 2020

Conversation

oibind
Copy link
Contributor

@oibind oibind commented May 12, 2020

ISSUE-263

Description

Update social icons. Have only updated the Slack icon and added Instagram as attempting to add any more results in it looking too cumbersome.

Before After
before after

@oibind oibind requested a review from awflwafl May 12, 2020 17:24
@oibind oibind linked an issue May 12, 2020 that may be closed by this pull request
Add Social Media Links for the Accounts We Have Out There #263
Open
@oibind oibind requested a review from chris18890 May 12, 2020 17:25
@awflwafl
Copy link
Member

Nice! There's finally a Slack icon. I'll check this out a bit later today.

@oibind
Copy link
Contributor Author

oibind commented May 12, 2020

Thank @elixier01. They added the stylesheet for Font Awesome.

awflwafl
awflwafl approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@awflwafl awflwafl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@awflwafl awflwafl merged commit edd587e into master May 12, 2020
@oibind oibind deleted the social-links branch May 12, 2020 22:11
chris18890
chris18890 reviewed Feb 27, 2021
View reviewed changes
Copy link
Member

@chris18890 chris18890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris18890 chris18890 chris18890 left review comments

@awflwafl awflwafl awflwafl approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Social Media Links for the Accounts We Have Out There
3 participants
@oibind @awflwafl @chris18890