feat(route): group leave event route #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainGuarinoni
requested changes
Mar 22, 2022
Comment on lines
+72
to
+82
| //searching for the event in the list of the events already joined | ||
| let found = false; | ||
| let index: number; | ||
|
|
||
| for(let e of group.events) { | ||
| if (e === eventToLeave){ | ||
| found = true; | ||
| index = group.events.indexOf(e); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Could use array.indexOf instead, it will be more clear
| import { HandlerDefinition } from '../../../../types/typing'; | ||
|
|
||
| const schema: HandlerDefinition = { | ||
| path: '/groups/event/leave', |
There was a problem hiding this comment.
events instead of event
Comment on lines
+16
to
+19
| properties: { | ||
| groupId: { type: 'string' }, | ||
| eventId: { type: 'string' }, | ||
| }, |
There was a problem hiding this comment.
We talked about it few days ago but now i do think it's better to do a path like this
/groups/{groupId}/events/{eventId}/leave, it's way more clear when we read the path of the route to undestand what it does !
There was a problem hiding this comment.
I think it's better because the path of a route need to defineds an entity, for example :
/musiciansdefines all the musicians/musicians/{musicianId}defines one musician
so it is clear than /groups/{groupId}/events/{eventId}/leave defines the fact that the group groupId want to leave the event eventId
Comment on lines
13
to
+14
| router.post('/event/join', groupController.groupJoinEvent); | ||
| router.delete('/event/delete', groupController.groupLeaveEvent); |
There was a problem hiding this comment.
same here, events instead of event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested yet, will do later. @RomainGuarinoni if you want test it in the mean time