Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services manager breaks long lines into 1023 bytes portions when using isc_info_svc_line in Service::query() #7141

Closed
AlexPeshkoff opened this issue Mar 3, 2022 · 2 comments

Comments

@AlexPeshkoff
Copy link
Member

Using long lines of base64 text with isc_info_svc_line is useful when dealing with trace plugin in order to transfer actually binary data to the client. This may appear strange choice but it helps to make trace process better interactive at the same time using single packet per trace event. But currently services manager is not ready for long (>=1Kb) lines transfer, causing need of strange code on client to process such packets and network traffic overhead (more packets than really needed).

@aafemt
Copy link
Contributor

aafemt commented Mar 3, 2022

Shouldn't such truncated lines be ended with isc_info_truncated?

@AlexPeshkoff
Copy link
Member Author

They will be ended with isc_info_truncated - if do not fit into user's buffer. Normally services manager will send as long lines as fit into that buffer. Limitation of 1Kb is/was artificial and caused by code of services manager.

AlexPeshkoff added a commit that referenced this issue Mar 10, 2022
…ons when using isc_info_svc_line in Service::query()
AlexPeshkoff added a commit that referenced this issue Mar 10, 2022
…ons when using isc_info_svc_line in Service::query()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment