Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is FCPDWorkbench ready for 1.0 release ? #33

Closed
luzpaz opened this issue Sep 8, 2024 · 3 comments
Closed

Is FCPDWorkbench ready for 1.0 release ? #33

luzpaz opened this issue Sep 8, 2024 · 3 comments

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Sep 8, 2024

@FlachyJoe
Copy link
Owner

Tested with 1.0RC, it works as expected.

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 11, 2024

@FlachyJoe Just out of curiosity, does it work on Qt6 builds ?

@FlachyJoe
Copy link
Owner

FlachyJoe commented Sep 11, 2024

@luzpaz Done !
tested with

OS: Debian GNU/Linux trixie/sid (XFCE/xfce)
Word size of FreeCAD: 64-bit
Version: 1.0.0RC1.38690 +2 (Git)
Build type: Release
Branch: fix_14663
Hash: f3eb286a8b6ef5e5a2e439e8ebf3194c80410b86
Python 3.12.6, Qt 6.6.2, Coin 4.0.2, Vtk 9.3.0, OCC 7.8.2.dev
Locale: English/United States (en_US) [ OS: French/France (fr_FR) ]
Stylesheet/Theme/QtStyle: /Classic/
Installed mods: 
  * fcpd-workbench 0.3.0

I spent some time to find a way to import PySide2 or PySide6 depends on the FreeCAD Qt version.
To finally fall to

def getQtVersion():
   if FreeCADGui.getMainWindow().__module__.startswith("PySide2"):
       return 5
   else:
       return 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants