Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content.render slide -1 content_from_pid #1640

Open
prdt3e opened this issue Apr 21, 2020 · 7 comments
Open

content.render slide -1 content_from_pid #1640

prdt3e opened this issue Apr 21, 2020 · 7 comments

Comments

@prdt3e
Copy link

prdt3e commented Apr 21, 2020

Typo3: 10.2
VHS: 6

I have a globe that has content_from_pid Home-Site.
However, it shows the content of the globe with slide = "- 1".
The error is probably caused by content_from_pid.
I remove slide = "- 1" it works with content_from_pid but no inheritance anymore.

@prdt3e
Copy link
Author

prdt3e commented Apr 24, 2020

So I analyzed that.
The error stems from getRootLine (Service/PageService.php).
It appears that getRootLine has been removed from pageRepository: #85557.

$rootline = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Utility\RootlineUtility::class, $pageUid)->get();

RootlineUtility is backward compatible.
What do you think?

@josefglatz

@NamelessCoder
Copy link
Member

RootlineUtility is backward compatible.

Including on TYPO3 8.7?

@prdt3e
Copy link
Author

prdt3e commented Apr 25, 2020

suggestion

use TYPO3\CMS\Core\Utility\RootlineUtility;

if (false === isset(static::$cachedRootlines[$cacheKey])) {
    $rootline = GeneralUtility::makeInstance(RootlineUtility::class, $pageUid);
    try {
        $rootline = $rootline->get();
    } catch (\RuntimeException $ex) {
        if (isset($GLOBALS['TSFE'])) {
            $rootline = (array) $GLOBALS['TSFE']->rootLine;
        } else {
            $rootline = [];
        }
    }
    if (true === $reverse) {
        $rootline = array_reverse($rootline);
    }
    static::$cachedRootlines[$cacheKey] = $rootline;
}

Now the disableGroupAccessCheck is still missing.
But I think this has had no effect for a long time, because in 9.5 the pagerepository only instanced RootlineUtility.

@prdt3e
Copy link
Author

prdt3e commented Jul 14, 2020

Does nobody have the problem with v10?

@josefglatz
Copy link
Contributor

Does nobody have the problem with v10?

Sorry, I don't use that feature anymore from vhs anymore. I'm using my own TypoScript since I don't want to rely too much on 3rd party extensions - even if it feels more productive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants