Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure as NNlib.within_grad is deleted #349

Closed
mcabbott opened this issue Jan 7, 2023 · 1 comment · Fixed by #350
Closed

Failure as NNlib.within_grad is deleted #349

mcabbott opened this issue Jan 7, 2023 · 1 comment · Fixed by #350

Comments

@mcabbott
Copy link
Member

mcabbott commented Jan 7, 2023

Flux's downstream tests see a failure with latest NNlib, because this line calls a function which no longer exists:

dx = if NNlib.within_grad()

Removed in FluxML/NNlib.jl#434. One path would be just to upgrade here. Another would be to make an NNlib PR adding a deprecation for the removed function (which was assumed to be internal); this option would keep old versions of this package working with new NNlib.

@yuehhua
Copy link
Member

yuehhua commented Jan 8, 2023

@mcabbott Thank you so much for raising this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants