fix(download-microservices): handle the ms urls in the correct way #988
Conversation
… caddyfile ingore only the default ones (ms type) since this path is handled by the reverse proxy
matteo-cristino
changed the title
|
Release cc7f5da to https://988.pr.didroom.com |
| @@ -32,10 +32,10 @@ SPDX-License-Identifier: AGPL-3.0-or-later | |||
| $: issuanceFlowQr = generateQr( | |||
| createIntentUrl({ | |||
| credential_configuration_ids: [service.type_name], | |||
| credential_issuer: credential_issuer.endpoint, | |||
| credential_issuer: credential_issuer.endpoint.endsWith('/credential_issuer') ? credential_issuer.endpoint : `${credential_issuer.endpoint}/credential_issuer`, | |||
There was a problem hiding this comment.
I see the intent to overcome automagically error prone endpoints, that is lovely. But you suppose that the credential_issuer is not correct if left at the end of a string. I would prefer to not suppose but maybe have a real check, like check that gives you a 404 or a 200... you can go with a small helper that does a simple HTTP method and checks the status. Then you choose the one that is correct for the better. Actually also accurate checks can be done, but guess that for now is super fine. Something like
credential_issuer: `${sanitizeCredentialIssuerEndpoint(credential_issuer.endpoint)}`| grants: { | ||
| authorization_code: { | ||
| authorization_server: authorization_server.endpoint | ||
| authorization_server: authorization_server.endpoint.endsWith('/authz_server') ? authorization_server.endpoint : `${authorization_server.endpoint}/authz_server`, |
| @@ -19,7 +19,8 @@ export const config = { | |||
| credential_issuer: 'openid-credential-issuer', | |||
| relying_party: 'openid-relying-party' | |||
| }, | |||
| env_example: '.env.example' | |||
| env_example: '.env.example', | |||
| dockerfile: 'Dockerfile' | |||
There was a problem hiding this comment.
SUPER PRO AND USELESS TIP: leave the final comma also to the end of the list item of an array/object (so next time in diff there is no the previous line changed ;) unless it's JSON, valid for js/ts objects.
|
|
||
| // | ||
|
|
||
| export function add_microservice_dockerfile(zip: AdmZip, microservice: Microservice, microservice_folder: MicroserviceFolder) { |
There was a problem hiding this comment.
I really feel bad on having half methods snake_case and half in camelCase... please agree and choose one convention and stick to it ;(
No description provided.