-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robust file dependency download process #206
Comments
Issue splits into two issues
First issue is probably easier to solve than second one. |
Regarding issue B, we could potentially query OSF for the files we expect to download. This can be done fairly easily with curl. For example, the node ID for the spectral files is This provides a JSON dataset which lists all of the folders and files within the node. We can the recursively follow the folders to make a tree of files. For each file, OSF also provides an MD5 hash that can be used to verify that each of the files downloaded fine. In the same JSON dataset, we also get download links for each file. We could also consider using this as an alternative to the current |
Working example in the notebook here: This provides functions for listing all files in a node, getting the download URL for a given file path on OSF, and obtaining MD5 hashes. This is done without using the old |
Sometimes the tests fail because the model is not able to get data from OSF. This can usually be fixed by requesting the test to be run again, in which case the data usually downloads fine.
Example of it failing: https://github.com/FormingWorlds/PROTEUS/actions/runs/11366750494/job/31617828810
We could include a loop in the downloader functions that re-attempts the download if an error is thrown.
The text was updated successfully, but these errors were encountered: