Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub workflow sometimes fails on MacOS #280

Closed
nichollsh opened this issue Nov 21, 2024 · 4 comments
Closed

GitHub workflow sometimes fails on MacOS #280

nichollsh opened this issue Nov 21, 2024 · 4 comments
Assignees
@nichollsh
Labels
bug Something isn't working help wanted Extra attention is needed JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation Tests Automated tests across the PROTEUS ecosystem

Comments

@nichollsh
Copy link
Contributor

nichollsh commented Nov 21, 2024 •
edited
Loading

Sometimes the MacOS test workflow fails on the step where it installs the brew dependencies. This is the first step of the workflow, so it's not directly related to core PROTEUS code. See example here: https://github.com/FormingWorlds/PROTEUS/actions/runs/11953651244/job/33321985018

To Reproduce
Run the test workflow with a MacOS runner.

Expected behavior
For brew to execute without errors.

Additional context
These seem to be the same problem: Homebrew/brew#17224, apache/arrow#44798
@nichollsh nichollsh added bug Something isn't working help wanted Extra attention is needed software Relating to software and implementation Priority 3: standard Priority level 3: medium time criticality or importance JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Tests Automated tests across the PROTEUS ecosystem labels Nov 21, 2024
@nichollsh nichollsh moved this to JOSS Publication in PROTEUS Development Roadmap Nov 21, 2024
@nichollsh
Copy link
Contributor Author

@stefsmeets do you have any suggestions for how to fix this?

@stefsmeets
Copy link
Contributor

stefsmeets commented Nov 21, 2024 •
edited
Loading

Could we mimick the apache changes:

https://github.com/raulcd/arrow/blob/e45627d759bb499ee58e72de42a7ea7319cc2204/.github/workflows/python.yml#L192-L195

# pkg-config formula is deprecated but it's still installed
# in GitHub Actions runner now. We can remove this once
# pkg-config formula is removed from GitHub Actions runner.
brew uninstall pkg-config || :

Seems like pkgconf is already installed and brew fails to recognize this and somehow does not have rights to overwrite it.

@nichollsh
Copy link
Contributor Author

Thanks! Seems simple enough.

@nichollsh nichollsh mentioned this issue Nov 22, 2024
Merged
@nichollsh nichollsh self-assigned this Nov 22, 2024
@nichollsh
Copy link
Contributor Author

Closed by #282

@github-project-automation github-project-automation bot moved this from In Progress to Done in PROTEUS Development Roadmap Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nichollsh nichollsh

Labels
bug Something isn't working help wanted Extra attention is needed JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Priority 3: standard Priority level 3: medium time criticality or importance software Relating to software and implementation Tests Automated tests across the PROTEUS ecosystem
Projects
PROTEUS Development Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefsmeets @nichollsh