Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test from vendored go #343

Open
photosheep opened this issue Aug 1, 2024 · 1 comment
Open

Failing test from vendored go #343

photosheep opened this issue Aug 1, 2024 · 1 comment

Comments

@photosheep
Copy link
Contributor

The latest (0.15.0+) update runs into breaking tests when vendoring.

[   10s] go test -v ./...
[   10s] # github.com/google/go-tpm-tools/simulator/internal
[   10s] vendor/github.com/google/go-tpm-tools/simulator/internal/internal_cgo.go:44:11: fatal error: Platform.h: No such file or directory
[   10s]    44 | // #include "Platform.h"
[   10s]       |           ^~~~~~~~~~~~
[   10s] compilation terminated.

I've fixed this by manually cloning v0.4.4 of go-tpm-tools and copying the simulator directory over to our vendor tarball. It seems as though a set of files are missed.

I'm not sure if this is the appropriate place but I've never encountered this issue before when packaging Go apps.
Thanks!

@Foxboron
Copy link
Owner

Foxboron commented Aug 1, 2024

Right, internal_cgo.go should call pkg-config or have some way to figure out the relative path of the vendor folder. I don't think this is a sbctl bug strictly speaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants