Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python frontend: async functions #1651

Open
Tracked by #394
maximiliankaul opened this issue Aug 14, 2024 · 1 comment
Open
Tracked by #394

Python frontend: async functions #1651

maximiliankaul opened this issue Aug 14, 2024 · 1 comment
Labels

Comments

@maximiliankaul
Copy link
Contributor

Decide how to handle the async Python stuff. Currently, this is mostly "not supported" and yields a ProblemNode.
Ideas:

  • these are basically the same as the non-async stuff -> make them inherit from the non-async classes and use the same functions in the handlers.
    • Pro: less duplicate code 👍
    • Con: this violates the Python AST grammar where they do not inherit form the non-async classes. I would like to have this reflected in our code (I only care about the Python.kt file here. If someone knows some kotlin magic to keep them separated there and still use the same implementations in the handlers 🥳 ).
  • keep them separate -> duplicate code. We still need to implement (copy) the async stuff then.
  • better ideas?
@maximiliankaul
Copy link
Contributor Author

The duplicate code was removed with #1673

Remaining task:

  • decide how to represent async in the graph and implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant