Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink Logouts #58

Open
bellebaum opened this issue Mar 1, 2022 · 1 comment
Open

Rethink Logouts #58

bellebaum opened this issue Mar 1, 2022 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@bellebaum
Copy link
Contributor

bellebaum commented Mar 1, 2022

Omejdn offers an endpoint /logout accepting GET and POST requests, as well as a request parameter post_logout_redirect_uri. This bears some similarities to the end_session_endpoint defined in OIDC RP-Initiated Logout.
However, where RPIL has at least some security built in with regards to several attacks, including

  • Using the OP as an open redirector, and
  • Involuntarily logging out the user from arbitrary services,

Omejdn has none. In fact, Omejdn is simply deleting the user's login session before redirecting the user back to whatever URL was passed as a parameter.

Going with the terminology of the above draft, a user thinks of "logging out at a RP" as revoking any access rights of an RP via the OP. This is trickier than implementing RPIL, since RPIL only covers OpenID Sessions (to log out, a RP will send an id_token_hint) and a user will likely want to be able to revoke access of arbitrary OAuth capable services, likely via an Omejdn GUI. This in turn requires proper token revocation and optionally a method to notify OIDC RPs (such as OIDC Front/Backchannel Logout).

For the time being, the following should be implemented:

  • OIDC RPIL as open-redirect protection.
  • A logout confirmation page
@bellebaum bellebaum added bug Something isn't working enhancement New feature or request labels Mar 1, 2022
@bellebaum bellebaum self-assigned this Mar 1, 2022
@bellebaum
Copy link
Contributor Author

The immediate changes have been implemented in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant