Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"check_for_orphan_assets" gitlab task breaks build #832

Open
dtenenba opened this issue Dec 12, 2022 · 4 comments
Open

"check_for_orphan_assets" gitlab task breaks build #832

dtenenba opened this issue Dec 12, 2022 · 4 comments
Assignees
@dtenenba
Labels
bug Something isn't working with the site or search itself structural A site structural change would be needed for this.

Comments

@dtenenba
Copy link
Contributor

This task wants to run gh to file an issue, but this requires first running gh auth login.
That shouldn't be too hard (need to log in as a service user) but I am commenting this out for now so as not to break the wiki.
@dtenenba come back to this and fix it.

But FYI, there are orphan assets:

assets/DaSL-NIHDataSharing/FHDaSLDMSPCheckList.docx
assets/DaSL-NIHDataSharing/FHDaSLNIHDMSPGuidance.docx
assets/DaSL-NIHDataSharing/FHDaSLNIHDMSPTemplateText.docx
assets/DaSL-NIHDataSharing/NIHDMSPCheatSheet.pdf
@dtenenba dtenenba added the bug Something isn't working with the site or search itself label Dec 12, 2022
@dtenenba dtenenba self-assigned this Dec 12, 2022
@vortexing
Copy link
Collaborator

Related to #912

@dtenenba
Copy link
Contributor Author

dtenenba commented Sep 8, 2023

The orphan assets listed above have been deleted but we still need to file an issue when there is new orphan content (don't keep adding issues with every build for the same orphan assets).

@vortexing vortexing added the structural A site structural change would be needed for this. label May 9, 2024
@vortexing
Copy link
Collaborator

@dtenenba did we ever clean this up?

@dtenenba
Copy link
Contributor Author

dtenenba commented May 9, 2024

So this does appear to run during builds on the main branch. It doesn't file an issue (yet) though. So you have to look at the build logs which people can only do if they have direct write permission on this repo.
Anyway there are no orphan assets right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtenenba dtenenba

Labels
bug Something isn't working with the site or search itself structural A site structural change would be needed for this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtenenba @vortexing