Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim trailing whitespace from documentation #24

Closed
wants to merge 3 commits into from
Closed

Trim trailing whitespace from documentation #24

wants to merge 3 commits into from

Conversation

shubhusion
Copy link

Fixes #10

@vercel
Copy link

vercel bot commented Oct 26, 2023

@shubhusion is attempting to deploy a commit to the Front Matter Team on Vercel.

A member of the Team first needs to authorize it.

@estruyf
Copy link
Member

estruyf commented Oct 27, 2023

Thanks @shubhusion for your changes, I've added some comments.

@shubhusion
Copy link
Author

@estruyf resolved conflicts. Kindly review the PR.

@estruyf
Copy link
Member

estruyf commented Oct 30, 2023

@shubhusion I don't yet see the proposed changes. Did you push your commit?

@shubhusion
Copy link
Author

shubhusion commented Oct 30, 2023 •
edited
Loading

yeah i have pushed the commit.
Link: c067a5f

@estruyf
Copy link
Member

estruyf commented Oct 30, 2023

Oh, but that commit doesn't contain the pending review changes.

@shubhusion
Copy link
Author

I will do the PR again then

@shubhusion shubhusion closed this Oct 30, 2023
@estruyf estruyf self-assigned this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estruyf estruyf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Trim trailing whitespace from documentation
2 participants
@shubhusion @estruyf