Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filtering by CTCF (or other featuers) #27

Closed
gfudenberg opened this issue Sep 28, 2022 · 3 comments
Closed

filtering by CTCF (or other featuers) #27

gfudenberg opened this issue Sep 28, 2022 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@gfudenberg
Copy link
Collaborator

for filtering by nearby features, current idea is to use 2x maximum padding as default.
Q: should this also be exposed as an extra number that can be provided in CLI

another Q is if all filtering functions can be refactored to
filter_by_table(sites, file_name, schema, exlude_bp, cols1, cols2, ...)

and if rmsk schema should go into bioframe

@gfudenberg gfudenberg added enhancement New feature or request question Further information is requested labels Sep 28, 2022
@PSmaruj
Copy link
Collaborator

PSmaruj commented Sep 28, 2022

Zrzut ekranu 2022-09-28 o 12 47 31

I explored what are the differences between df length depending on the `exclude_window` For rmsk, I've chosen `exclude_window = flank_end` (so here, `30`) as default

For ctcf's - there's no difference:
Zrzut ekranu 2022-09-28 o 12 52 25
So, I've chosen ctcf_exclude_window = 2 * flank_end (so here, 60) as default

@gfudenberg
Copy link
Collaborator Author

will also be able to modify filter_by_rmsk if we add the schema to bioframe

def filter_by_rmsk(

bullet point one:
open2c/bioframe#123

@gfudenberg
Copy link
Collaborator Author

superseded by #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants