Add GPU flavor list commands for baremetal and virtual GPU resources #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement comprehensive GPU flavor management: - Add flavor list commands for baremetal and virtual GPU resources - Create CLI commands with support for including prices and disabled flavors - Develop service client methods for retrieving GPU flavor lists - Integrate new flavor commands into the GPU command structure
- Update flavor list command to exclude disabled flavors by default - Modify flavor list options to invert disabled flag logic - Enhance flavor price structure with more detailed price information - Improve error handling in flavor list query generation
- Correct package name in client/gpu/v3/commands.go from v3 to gpu - Update import statements in cmd/commands.go to use the new package name - Ensure consistent package naming across GPU-related files
deferred
reviewed
Feb 20, 2025
gcore/gpu/v3/flavors/urls.go
Outdated
| } | ||
|
|
||
| // FlavorURL returns URL for specific GPU flavor operations | ||
| func FlavorURL(c *gcorecloud.ServiceClient, flavorID string) string { |
There was a problem hiding this comment.
Deleted, thanks!
- Rename "disabled" flag to "show-disabled" for clarity - Modify flag alias from "dis" to "sd" - Invert flag logic to explicitly show disabled flavors when flag is set - Update usage description to clarify default behavior
- Delete unnecessary FlavorURL function from flavors/urls.go - Simplify package by removing unused URL generation method
- Add new PriceDisplayStatus "error" to handle price-related errors - Replace generic 'any' type with decimal.Decimal for price fields - Improve type safety and precision for flavor pricing information
- Rename "show-disabled" flag to "exclude-disabled" - Change flag alias from "sd" to "ed" - Invert flag logic to exclude disabled flavors by default - Update usage description to clarify new behavior
pedrodeoliveira
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement comprehensive GPU flavor management: