Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect that NY is divisible by 6 in MAPL_GridCreate #3164

Open
bena-nasa opened this issue Nov 7, 2024 · 1 comment
Open

Protect that NY is divisible by 6 in MAPL_GridCreate #3164

bena-nasa opened this issue Nov 7, 2024 · 1 comment
Assignees
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature

Comments

@bena-nasa
Copy link
Collaborator

bena-nasa commented Nov 7, 2024

In MAPL2 we have this convention per-face layout of the cube is NX and NY/6, however it looks like in MAPL_GridCreate we do not actually protect that NY is divisible by 6, but the division by 6 is what is passed to the cubed-sphere grid factory. This resulted in an error I helped @rtodling debug. He was passing a 9x40 layout and the model was crashing in fms. But 40 is not divisible by six, so I suspect ultimately fms was getting a 9x6 or 9x7 layout, (does it take the floor or ceiling), when 40 was divided by 6; either way the model communicator was on 360 cores so fms complained since the layout it was given was incompatible with the communicator. So we should probably protect in MAPL_GridCreate rather than than let this get all the way to FMS or other places. I don't know if places outside of MAPL do this, like if FV3 grid comp is doing the same by 6 division but either easy to simply to add an assert here with an informative message.

@bena-nasa bena-nasa self-assigned this Nov 7, 2024
@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Nov 7, 2024
@mathomp4
Copy link
Member

mathomp4 commented Nov 8, 2024

Ooh. This might be a good reason for a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

No branches or pull requests

2 participants