From 442a000fb87011a177c74e1c65ae99f02f3a0a5f Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Thu, 7 Nov 2024 15:13:34 +0100 Subject: [PATCH 01/14] refactor: changed order of indicators in indicators.yaml (this also changes the order in the swagger docs) #609 --- ohsome_quality_api/indicators/indicators.yaml | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/ohsome_quality_api/indicators/indicators.yaml b/ohsome_quality_api/indicators/indicators.yaml index 7dff4a8a7..4ad3a97b7 100644 --- a/ohsome_quality_api/indicators/indicators.yaml +++ b/ohsome_quality_api/indicators/indicators.yaml @@ -1,4 +1,21 @@ --- +mapping-saturation: + name: Mapping Saturation + projects: + - core + - corine-land-cover + - expanse + - experimental + - idealvgi + - mapaction + - sketchmap + - bkg + - unicef + quality_dimension: completeness + description: >- + Calculate if mapping has saturated. + High saturation has been reached if the growth of the fitted curve is + minimal. density: name: Density projects: @@ -36,23 +53,6 @@ road-comparison: description: >- Compare the road length of OSM roads with the road length of reference data. -mapping-saturation: - name: Mapping Saturation - projects: - - core - - corine-land-cover - - expanse - - experimental - - idealvgi - - mapaction - - sketchmap - - bkg - - unicef - quality_dimension: completeness - description: >- - Calculate if mapping has saturated. - High saturation has been reached if the growth of the fitted curve is - minimal. building-comparison: name: Building Comparison projects: From d1ae003c09a3dadf20b8379b8f5ce138b91b4828 Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Thu, 14 Nov 2024 13:26:18 +0100 Subject: [PATCH 02/14] feat: tried implementing some new attributes. One test ist non-functional for trial purposes --- ohsome_quality_api/attributes/attributes.yaml | 8 ++++++++ tests/conftest.py | 7 ++++++- .../indicators/test_attribute_completeness.py | 3 ++- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index 329e43955..fe48ead5e 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -293,3 +293,11 @@ roads: name: Speed Camera description: TODO filter: highway:speed_camera=* + lit: + name: Lit + description: TODO + filter: lit=* and lit!=no and lit!=disused and lit!=yes + residential: + name: Residential road + description: Road in a residential area + filter: highway=residential diff --git a/tests/conftest.py b/tests/conftest.py index bcee3fea8..0b843c23d 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -43,6 +43,11 @@ def topic_key_building_count() -> str: return "building-count" +@pytest.fixture(scope="class") +def topic_roads() -> TopicDefinition: + return get_topic_preset("roads") + + @pytest.fixture(scope="class") def topic_minimal(topic_key_minimal) -> TopicDefinition: return get_topic_preset(topic_key_minimal) @@ -137,7 +142,7 @@ def attribute() -> Attribute: @pytest.fixture(scope="class") def attribute_key() -> str: - return ["height"] + return ["residential"] @pytest.fixture(scope="class") diff --git a/tests/integrationtests/indicators/test_attribute_completeness.py b/tests/integrationtests/indicators/test_attribute_completeness.py index 53d6b1b47..3b5e36aab 100644 --- a/tests/integrationtests/indicators/test_attribute_completeness.py +++ b/tests/integrationtests/indicators/test_attribute_completeness.py @@ -102,9 +102,10 @@ def indicator( topic_building_count, feature_germany_heidelberg, attribute_key, + topic_roads, ): indicator = AttributeCompleteness( - topic_building_count, + topic_roads, feature_germany_heidelberg, attribute_key, ) From 3bdb37292990f087d6252eb4c3f48c0abd6b3f11 Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Thu, 21 Nov 2024 15:39:48 +0100 Subject: [PATCH 03/14] feat: added some new attributes for attribute completeness --- ohsome_quality_api/attributes/attributes.yaml | 34 ++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index fe48ead5e..702aa289c 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -67,6 +67,14 @@ building-count: name: Colour of Buildings description: TODO filter: building:colour=* + missing-wall: + name: Missing Wall + description: slight constructions like sheds or any construction with a roof and at least one side open or without foundations. + filter: wall=no + source: + name: Source + description: TODO + filter: source=* bus-stops: public-transport-platform: @@ -77,6 +85,10 @@ bus-stops: name: Bus stop area description: TODO filter: public_transport=stop_area + shelter: + name: shelter + description: TODO + filter: shelter=* clinics: healthcare-birthing-centre: @@ -131,6 +143,10 @@ forests: name: Forest boundary description: TODO filter: boundary=forest + leaf-type: + name: Leaf Type + description: TODO + filter: leaf_type=* kindergarten: leisure-playground: @@ -159,6 +175,14 @@ marketplaces: name: Winery description: TODO filter: craft=winery + opening-hours: + name: Opening Hours + description: TODO + filter: opening_hours=* + shop-name: + name: Shop Name + description: TODO + filter: name=* parks: landuse-commercial: @@ -235,6 +259,14 @@ supermarkets: name: Parking entrance description: TODO filter: amenity=parking_entrance + brand: + name: Brand + description: TODO + filter: brand=* + opening-hours: + name: Opening Hours + description: TODO + filter: opening_hours=* tram-stops: public-transport-stop-area: @@ -296,7 +328,7 @@ roads: lit: name: Lit description: TODO - filter: lit=* and lit!=no and lit!=disused and lit!=yes + filter: lit=* and lit!=no and lit!=disused residential: name: Residential road description: Road in a residential area From 5418e64a14e96c0dbfcf772a08f25df9258b9cc7 Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Fri, 22 Nov 2024 09:20:24 +0100 Subject: [PATCH 04/14] fix: changed a nonfunctional attribute filter #850 --- ohsome_quality_api/attributes/attributes.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index 702aa289c..b1c226683 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -304,7 +304,7 @@ roads: cycleway-share-busway: name: Cycleway Share Busway description: TODO - filter: cycleway:share_busway=* + filter: cycleway=share_busway parking: name: Parking description: TODO From 429d6044813f613b063f26780c5f693aad5753ca Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Fri, 22 Nov 2024 13:05:23 +0100 Subject: [PATCH 05/14] feat: added more new attributes --- ohsome_quality_api/attributes/attributes.yaml | 74 ++++++++++++++++++- 1 file changed, 73 insertions(+), 1 deletion(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index b1c226683..518237b64 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -107,6 +107,54 @@ clinics: name: Vaccination centre description: TODO filter: healthcare=vaccination_centre + opening-hours: + name: Opening Hours + description: TODO + filter: opening_hours=* + specialty: + name: specialty + description: TODO + filter: healthcare:speciality=* + +doctors: + phone-number: + name: Phone Number + description: TODO + filter: phone=* + name: + name: Name + description: TODO + filter: name=* + specialty: + name: Specialty + description: TODO + filter: healthcare:speciality=* + opening-hours: + name: Opening Hours + description: TODO + filter: opening_hours=* + Website: + name: Website + description: TODO + filter: website=* + +hospitals: + emergency: + name: Emergency + description: TODO + filter: emergency=* + name: + name: Name + description: TODO + filter: name=* + specialty: + name: Specialty + description: TODO + filter: healthcare:speciality=* + opening-hours: + name: Opening Hours + description: TODO + filter: opening_hours=* fitness-centres: sport-fitness: @@ -121,6 +169,14 @@ fitness-centres: name: Weightlifting description: TODO filter: sport=weightlifting + sport: + name: Sport + description: TODO + filter: sport=* + opening-hours: + name: Opening Hours + description: TODO + filter: opening_hours=* forests: access-private: @@ -153,6 +209,10 @@ kindergarten: name: Playground description: TODO filter: leisure=playground + phone-number: + name: Phone Number + description: TODO + filter: phone=* marketplaces: craft-bakery: @@ -211,6 +271,18 @@ schools: name: Playground description: TODO filter: leisure=playground + name: + name: Name + description: TODO + filter: name=* + website: + name: Website + description: TODO + filter: website=* + phone-number: + name: Phone Number + description: TODO + filter: phone=* subway-stations: railway-subway: @@ -328,7 +400,7 @@ roads: lit: name: Lit description: TODO - filter: lit=* and lit!=no and lit!=disused + filter: lit=* residential: name: Residential road description: Road in a residential area From 5a77a129d52a9da7abdb0edbee41f77bfa99606f Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Mon, 25 Nov 2024 10:56:42 +0100 Subject: [PATCH 06/14] feat: added a new topic and more new attributes and deleted one that doesn't work --- ohsome_quality_api/attributes/attributes.yaml | 38 +++++++++++++++++-- ohsome_quality_api/topics/presets.yaml | 15 ++++++++ 2 files changed, 49 insertions(+), 4 deletions(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index 518237b64..b62cd83dd 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -393,10 +393,6 @@ roads: name: Surface description: TODO filter: surface=* - highway-speed-camera: - name: Speed Camera - description: TODO - filter: highway:speed_camera=* lit: name: Lit description: TODO @@ -405,3 +401,37 @@ roads: name: Residential road description: Road in a residential area filter: highway=residential +car-roads: + name: + name: Road Name + description: TODO + filter: name=* + sidewalk: + name: Sidewalk + description: TODO + filter: sidewalk=* + lanes: + name: Lanes + description: TODO + filter: lanes=* + parking: + name: Parking + description: TODO + filter: parking:left=* or parking:right=* or parking:both=* + maxspeed: + name: Maxspeed + description: TODO + filter: maxspeed=* + oneway: + name: Oneway + description: TODO + filter: oneway=* + surface: + name: Surface + description: TODO + filter: surface=* + lit: + name: Lit + description: TODO + filter: lit=* + diff --git a/ohsome_quality_api/topics/presets.yaml b/ohsome_quality_api/topics/presets.yaml index 2ddf55036..c58551e16 100644 --- a/ohsome_quality_api/topics/presets.yaml +++ b/ohsome_quality_api/topics/presets.yaml @@ -55,6 +55,21 @@ roads: projects: - core - bkg +car-roads: + name: Classified Roads + description: roads excluding simple forest paths and other small/ unclassified roads + endpoint: elements + aggregation_type: length + filter: >- + highway in (motorway, trunk, primary, tertiary, residential, service, living_street, trunk_link) and type:way + indicators: + - mapping-saturation + - road-comparison + - attribute-completeness + - currentness + projects: + - core + - bkg railway-length: name: Railways From 184928aacf1c2e38b8aedf99761664edb0e65abd Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Mon, 25 Nov 2024 11:39:24 +0100 Subject: [PATCH 07/14] feat: added a new topic and more new attributes --- ohsome_quality_api/attributes/attributes.yaml | 34 +++++++++++++++++-- ohsome_quality_api/topics/presets.yaml | 20 +++++++++-- 2 files changed, 49 insertions(+), 5 deletions(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index b62cd83dd..da9319b48 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -380,7 +380,7 @@ roads: parking: name: Parking description: TODO - filter: parking:left=* or parking:right=* or parking:both=* + filter: parking:left=* or parking:right=* or parking:both=* or parking=* maxspeed: name: Maxspeed description: TODO @@ -401,6 +401,7 @@ roads: name: Residential road description: Road in a residential area filter: highway=residential + car-roads: name: name: Road Name @@ -417,7 +418,7 @@ car-roads: parking: name: Parking description: TODO - filter: parking:left=* or parking:right=* or parking:both=* + filter: parking:left=* or parking:right=* or parking:both=* or parking=* maxspeed: name: Maxspeed description: TODO @@ -435,3 +436,32 @@ car-roads: description: TODO filter: lit=* +public-transport-stops: + shelter: + name: Shelter + description: TODO + filter: shelter=* + bench: + name: Bench + description: TODO + filter: bench=* + trash-bin: + name: Trash Bin + description: TODO + filter: bin=* + tactile-paving: + name: Tactile Paving + description: TODO + filter: tactile_paving=* + wheelchair-accessibility: + name: Wheelchair Accessibility + description: TODO + filter: wheelchair=* + bus-lines: + name: Bus Lines + description: List of all bus lines stopping at a certain stop + filter: route_ref=* + departures-board: + name: Departures Board + description: TODO + filter: departures_board=* \ No newline at end of file diff --git a/ohsome_quality_api/topics/presets.yaml b/ohsome_quality_api/topics/presets.yaml index c58551e16..4f8a59707 100644 --- a/ohsome_quality_api/topics/presets.yaml +++ b/ohsome_quality_api/topics/presets.yaml @@ -55,16 +55,16 @@ roads: projects: - core - bkg + car-roads: name: Classified Roads description: roads excluding simple forest paths and other small/ unclassified roads endpoint: elements aggregation_type: length filter: >- - highway in (motorway, trunk, primary, tertiary, residential, service, living_street, trunk_link) and type:way + highway in (motorway, trunk, primary, secondary, tertiary, residential, service, living_street, trunk_link) and type:way indicators: - mapping-saturation - - road-comparison - attribute-completeness - currentness projects: @@ -225,7 +225,7 @@ bus-stops: tram-stops: name: Tram Stops - description: Count of schools. + description: Count of tram stops. endpoint: elements aggregation_type: count filter: railway=tram_stop @@ -238,6 +238,20 @@ tram-stops: - core - bkg +public-transport-stops: + name: Public Transport Stops + description: Count of public transport stops. + endpoint: elements + aggregation_type: count + filter: public_transport=platform + indicators: + - mapping-saturation + - currentness + - attribute-completeness + projects: + - core + - bkg + subway-stations: name: Subway Stations description: Count of subway stops. From 53e63a37c6b479c9c4164ce1dbad27ef36ce9e96 Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Mon, 25 Nov 2024 11:48:45 +0100 Subject: [PATCH 08/14] feat: changed the cycleway-share-busway attribute to make it apply to more objects #850 --- ohsome_quality_api/attributes/attributes.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index da9319b48..f8b07fae9 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -376,7 +376,7 @@ roads: cycleway-share-busway: name: Cycleway Share Busway description: TODO - filter: cycleway=share_busway + filter: cycleway=share_busway or cycleway:both=share_busway or cycleway:left=share_busway or cycleway:right=share_busway parking: name: Parking description: TODO From 89e549a82aa82250e43b2e68fcaa22d7097fd1f5 Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Thu, 28 Nov 2024 11:49:13 +0100 Subject: [PATCH 09/14] feat: added a new topic (Sports Pitch) with attributes for it and added the attribute-completeness indicator to some of the topic definitions --- ohsome_quality_api/attributes/attributes.yaml | 18 +++++++++++++++++ ohsome_quality_api/topics/presets.yaml | 20 ++++++++++++++++++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index f8b07fae9..9bce3de01 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -266,6 +266,24 @@ parks: description: TODO filter: leisure=playground +sports-pitch: + sport: + name: Sport + description: TODO + filter: sport=* + lit: + name: Lit + description: TODO + filter: lit=* + surface: + name: Surface + description: TODO + filter: surface=* + access: + name: Access + description: TODO + filter: access=* + schools: leisure-playground: name: Playground diff --git a/ohsome_quality_api/topics/presets.yaml b/ohsome_quality_api/topics/presets.yaml index 4f8a59707..020a7429e 100644 --- a/ohsome_quality_api/topics/presets.yaml +++ b/ohsome_quality_api/topics/presets.yaml @@ -62,7 +62,7 @@ car-roads: endpoint: elements aggregation_type: length filter: >- - highway in (motorway, trunk, primary, secondary, tertiary, residential, service, living_street, trunk_link) and type:way + highway in (motorway, trunk, primary, secondary, tertiary, residential, service, living_street, trunk_link, motorway_link, primary_link, secondary_link, tertiary_link) and type:way indicators: - mapping-saturation - attribute-completeness @@ -159,6 +159,7 @@ schools: indicators: - mapping-saturation - currentness + - attribute-completeness projects: - core - bkg @@ -204,6 +205,7 @@ doctors: indicators: - mapping-saturation - currentness + - attribute-completeness projects: - core - bkg @@ -312,6 +314,21 @@ parks: - core - bkg +sports-pitch: + name: Sports Pitch + description: Count of sports pitches (an area designed for practising a particular sport) + endpoint: elements + aggregation_type: count + filter: leisure=pitch + source: https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dpitch + indicators: + - mapping-saturation + - currentness + - attribute-completeness + projects: + - core + - bkg + forests: name: Forests description: Count of forests. @@ -392,6 +409,7 @@ hospitals: indicators: - mapping-saturation - currentness + - attribute-completeness projects: - core - bkg From 1d11ac6b36c569402e0267627449e0e1b6770614 Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Fri, 29 Nov 2024 11:17:30 +0100 Subject: [PATCH 10/14] feat: changed some attribute filters and deleted non-functional attributes --- ohsome_quality_api/attributes/attributes.yaml | 94 +------------------ 1 file changed, 5 insertions(+), 89 deletions(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index 9bce3de01..171eb7987 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -179,26 +179,6 @@ fitness-centres: filter: opening_hours=* forests: - access-private: - name: Private Access - description: TODO - filter: access=private - access-official: - name: Official Access - description: TODO - filter: access=official - access-forestry: - name: Forestry - description: TODO - filter: access=forestry - highway-track: - name: Track - description: TODO - filter: highway=track - boundary-forest: - name: Forest boundary - description: TODO - filter: boundary=forest leaf-type: name: Leaf Type description: TODO @@ -215,22 +195,6 @@ kindergarten: filter: phone=* marketplaces: - craft-bakery: - name: Bakery - description: TODO - filter: craft=bakery - craft-handicraft: - name: Handicraft - description: TODO - filter: craft=handicraft - craft-leather: - name: Leather craft - description: TODO - filter: craft=leather - craft-shoemaker: - name: Shoemaker - description: TODO - filter: craft=shoemaker craft-winery: name: Winery description: TODO @@ -245,26 +209,10 @@ marketplaces: filter: name=* parks: - landuse-commercial: - name: Commercial landuse - description: TODO - filter: landuse=commercial - leisure-dog-park: - name: Dog park - description: TODO - filter: leisure=dog_park tourism-theme-park: name: Theme park description: TODO filter: tourism=theme_park - landuse-greenfield: - name: Greenfield - description: TODO - filter: landuse=greenfield - leisure-playground: - name: Playground - description: TODO - filter: leisure=playground sports-pitch: sport: @@ -303,22 +251,10 @@ schools: filter: phone=* subway-stations: - railway-subway: - name: Subway - description: TODO - filter: railway=subway tunnel-yes: name: Tunnel description: TODO filter: tunnel=yes - railway-subway-entrance: - name: Subway entrance - description: TODO - filter: railway=subway_entrance - route-subway: - name: Subway route - description: TODO - filter: route=subway public-transport-stop-area: name: Subway stop area description: TODO @@ -329,26 +265,6 @@ subway-stations: filter: public_transport=platform supermarkets: - shop-convenience: - name: Convenience store - description: TODO - filter: shop=convenience - shop-beverages: - name: Beverages - description: TODO - filter: shop=beverages - amenity-bicycle-parking: - name: Bicycle Parking - description: TODO - filter: amenity=bicycle_parking - amenity-parking: - name: Parking - description: TODO - filter: amenity=parking - amenity-parking-entrance: - name: Parking entrance - description: TODO - filter: amenity=parking_entrance brand: name: Brand description: TODO @@ -382,15 +298,15 @@ roads: sidewalk: name: Sidewalk description: TODO - filter: footway:sidewalk=* + filter: sidewalk=* crossing: name: Crossing description: TODO - filter: footway:crossing = * - cycleway-lane: - name: Cycleway Lane + filter: crossing=* + cycleway: + name: Cycleway description: TODO - filter: cycleway:lane=* + filter: cycleway=* cycleway-share-busway: name: Cycleway Share Busway description: TODO From 9d7f2ac1aa6c68a851773c639599df13ca08b5af Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Fri, 29 Nov 2024 11:23:56 +0100 Subject: [PATCH 11/14] refactor: undo changes that were made for testing purposes --- tests/conftest.py | 2 +- .../integrationtests/indicators/test_attribute_completeness.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index 0b843c23d..090b291d8 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -142,7 +142,7 @@ def attribute() -> Attribute: @pytest.fixture(scope="class") def attribute_key() -> str: - return ["residential"] + return ["height"] @pytest.fixture(scope="class") diff --git a/tests/integrationtests/indicators/test_attribute_completeness.py b/tests/integrationtests/indicators/test_attribute_completeness.py index 3b5e36aab..53d6b1b47 100644 --- a/tests/integrationtests/indicators/test_attribute_completeness.py +++ b/tests/integrationtests/indicators/test_attribute_completeness.py @@ -102,10 +102,9 @@ def indicator( topic_building_count, feature_germany_heidelberg, attribute_key, - topic_roads, ): indicator = AttributeCompleteness( - topic_roads, + topic_building_count, feature_germany_heidelberg, attribute_key, ) From dcf870b376c3da103b93abf2e9261abffde186d5 Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Thu, 5 Dec 2024 11:21:26 +0100 Subject: [PATCH 12/14] feat: changed the definition of the supermarkets topic --- ohsome_quality_api/topics/presets.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ohsome_quality_api/topics/presets.yaml b/ohsome_quality_api/topics/presets.yaml index 020a7429e..d5407e3ac 100644 --- a/ohsome_quality_api/topics/presets.yaml +++ b/ohsome_quality_api/topics/presets.yaml @@ -274,7 +274,7 @@ supermarkets: description: Count of supermarkets. endpoint: elements aggregation_type: count - filter: shop=supermarket + filter: shop=supermarket or shop=convenience source: https://wiki.openstreetmap.org/wiki/Tag:shop%3Dsupermarket indicators: - mapping-saturation From 51bdcda5c1f9894a94f504952181bf7d2221cc9b Mon Sep 17 00:00:00 2001 From: JanReifenrath Date: Thu, 5 Dec 2024 11:51:51 +0100 Subject: [PATCH 13/14] refactor: added recent changes to the CHANGELOG.md --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a60584adc..22cd6a7bc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ## Current Main +- attribute completeness: improved figure description ([#828]) +- attribute completeness: fixed problem with an attribute filter ([#850]) +- attribute completeness: added new topic and topic - specific attributes and deleted non-functional attributes ## Release 1.7.0 From 6ff337e7fbc50905779154338b6c6d934a3b2342 Mon Sep 17 00:00:00 2001 From: Gigaszi Date: Tue, 7 Jan 2025 16:28:09 +0100 Subject: [PATCH 14/14] fix: typos --- ohsome_quality_api/attributes/attributes.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ohsome_quality_api/attributes/attributes.yaml b/ohsome_quality_api/attributes/attributes.yaml index 171eb7987..e8bc6a66e 100644 --- a/ohsome_quality_api/attributes/attributes.yaml +++ b/ohsome_quality_api/attributes/attributes.yaml @@ -112,7 +112,7 @@ clinics: description: TODO filter: opening_hours=* specialty: - name: specialty + name: Specialty description: TODO filter: healthcare:speciality=*