Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out duplicated code for comparison indicators #797

Open
Gigaszi opened this issue May 16, 2024 · 1 comment
Open

factor out duplicated code for comparison indicators #797

Gigaszi opened this issue May 16, 2024 · 1 comment

Comments

@Gigaszi
Copy link
Collaborator

Gigaszi commented May 16, 2024

The road comparison and building comparison indicator share a lot of code. We should factor this code out in a separate file

@matthiasschaub
Copy link
Collaborator

A solution could be to add another parent class in our inheritance hierarchy.
base > comparison > indicator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants