-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename geometry-filter "other" to geometrycollection and add more geom-filters #464
Comments
@tyrasd will check if this is still the case. |
Yes, the documentation is concise, but IMHO sufficient: ”matches anything which has a geometry of the given type (point, line, polygon, or other)” means that other is everything that is not a point, line or polygon.
|
but there is an inconsistency in: oshdb/oshdb-filter/src/main/java/org/heigit/ohsome/oshdb/filter/GeometryTypeFilter.java Lines 33 to 42 in 20bd2c8
because it links to I'm sorry for being such a nit-picker but downstream tools require me to be exact on my geometries. |
Problem Description
The geometry filter "other" is not well defined (at least not in the docu of the ohsome-api). It remains unclear what it contains, apart from geometry-collections.
Expected Solution
Be explicit on the filters. Add filters for Polygon vs MultiPolygon (vs Polygonal) etc.
Alternative Solutions
Document what 'other'-geometry type is.
### Additional ContextAdd any other context or screenshots about the feature request here.Related: #436
The text was updated successfully, but these errors were encountered: