Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffx_fsr3.cpp ffxFsr3ContextDestroy crash #114

Open
svatostop opened this issue Nov 21, 2024 · 1 comment
Open

ffx_fsr3.cpp ffxFsr3ContextDestroy crash #114

svatostop opened this issue Nov 21, 2024 · 1 comment

Comments

@svatostop
Copy link

Hi! We are trying to integrate FSR3 to the project using sources from sdk/ folder.
We are running on Windows/Linux using Vulkan.

After trying to destroy FSR3 Context I had a crash in ffxFsr3ContextDestroy. From my investigation it was happening due to double freeing of backend interface which is trying to be used in ffxFsr3UpscalerContextDestroy.

Commenting out contextPrivate->backendInterfaceSharedResources.fpDestroyBackendContext(&contextPrivate->backendInterfaceSharedResources, contextPrivate->effectContextIdSharedResources); fix the issue

@VeganPower
Copy link

I run in a similar problem in ffx_frameinterpolation.cpp
At line 995 and 1002 FFX_FRAMEINTERPOLATION_RESOURCE_IDENTIFIER_PRESENT_BACKBUFFER is registered as dynamic resource, but in frameinterpolationRelease is not unregisted from the "resources not created internally"
Adding

context->srvResources[FFX_FRAMEINTERPOLATION_RESOURCE_IDENTIFIER_PRESENT_BACKBUFFER ]                      = {FFX_FRAMEINTERPOLATION_RESOURCE_IDENTIFIER_NULL};

at line 553 fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants