Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckanext-spatial is not load ckan.ini config #4518

Closed
FuhuXia opened this issue Oct 31, 2023 · 4 comments
Closed

ckanext-spatial is not load ckan.ini config #4518

FuhuXia opened this issue Oct 31, 2023 · 4 comments
Labels
bug Software defect or bug

Comments

@FuhuXia
Copy link
Member

FuhuXia commented Oct 31, 2023

ckanext-spatial's map widget is configurable, such as this:

ckanext.spatial.common_map.type = custom
ckanext.spatial.common_map.custom.url = http://tile.stamen.com/watercolor/{z}/{x}/{y}.jpg
ckanext.spatial.common_map.attribution = Map tiles by <a href="http://stamen.com">Stamen Design</a>, under <a href="http://creativecommons.org/licenses/by/3.0">CC BY 3.0</a>. Data by <a href="http://openstreetmap.org">OpenStreetMap</a>, under <a href="http://creativecommons.org/licenses/by-sa/3.0">CC BY SA</a>.

This does not work in our catalog. It always use the default, current stamen-tiles. The attribution text is hard coded in the datagovtheme.

How to reproduce

Add above code block to .env or ckan.ini.

Expected behavior

Map widget shows new watercolor tiles.

Actual behavior

No change.

Sketch

[Notes or a checklist reflecting our understanding of the selected approach]

@nickumia
Copy link

nickumia commented Nov 2, 2023

Oh... is this the missing link in the following issue?

@btylerburton btylerburton moved this to 📔 Product Backlog in data.gov team board Nov 2, 2023
@brownterryn
Copy link

brownterryn commented Nov 6, 2023

Update: my fault, wasn't putting .ini entries under app:main section, just appending to end of file, leaving comment in case others make the same mistake. @FuhuXia ?

I'm trying to use the above (type = custom) to point to https://tile.openstreetmap.org/{z}/{x}/{y}.png (with and without the $s OSMs example shows) and it appears to have no effect, i.e. just the "No map provider set. Please check the documentation" text, no failed call to OSM in the log etc. Don't know if it's not reading .ini, or .ini formatting is wrong, but agree with OP and do not think the problem is an out of date link to Stamen.

@FuhuXia FuhuXia self-assigned this Nov 6, 2023
@FuhuXia
Copy link
Member Author

FuhuXia commented Nov 6, 2023

@brownterryn Thanks for the input. The issue we are having is custom ckan theme not loading latest ckanext-spatial snippet. Fix is on the way.

@FuhuXia FuhuXia moved this from 📔 Product Backlog to 🏗 In Progress [8] in data.gov team board Nov 7, 2023
@FuhuXia FuhuXia moved this from 🏗 In Progress [8] to 👀 Needs Review [2] in data.gov team board Nov 8, 2023
@FuhuXia
Copy link
Member Author

FuhuXia commented Nov 9, 2023

fixed in datagovtheme PR by updating to the latest spatial_query snippet. Configured map tile server in catalog PR.

@FuhuXia FuhuXia closed this as completed Nov 9, 2023
@github-project-automation github-project-automation bot moved this from 👀 Needs Review [2] to ✔ Done in data.gov team board Nov 9, 2023
@hkdctol hkdctol moved this from ✔ Done to 🗄 Closed in data.gov team board Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software defect or bug
Projects
Archived in project
Development

No branches or pull requests

3 participants