Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkinPort - MIT license, support for modern skins #12602

Closed
6 of 7 tasks
Rosenlied-Iris opened this issue Feb 15, 2023 · 4 comments
Closed
6 of 7 tasks

SkinPort - MIT license, support for modern skins #12602

Rosenlied-Iris opened this issue Feb 15, 2023 · 4 comments
Labels
Status: Stale Automatically close this issue in 2 weeks if there are no new responses Status: Triage Issue awaiting triage. Remove once this issue is processed Type: Mod Addition

Comments

@Rosenlied-Iris
Copy link

Your GTNH Discord Username

Rosenlied#3858

Your Pack Version

2.2.8-2.2.9

Mod Name

SkinPort

The Mod to Add

Adding built-in support for modern Minecraft skins, without the black bars.

Your Reason

New skins on older versions display poorly - this should fix it and allow them to render normally.

Preliminary Investigation

Attempting to add this mod to the 2.2.8 and 2.2.9 versions does not seem to have introduced issues, and this does not seem to significantly increase load time or lag.

This mod does not add any new items or features, and I assume it works on the client only as I couldn't seem to find a server file and it seems to work just fine on my locally hosted server - just not rendering for others without the mod.

Final Checklist

  • This mod is released under an open source license. Yes, this is required now.
  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying I like this mod, please reconsider adding it will prompt us to investigate and reopen it once we confirm your report.
  • I believe there is nothing similar in the pack already, or the existing solution isn't good enough.
  • I understand this change request may not attract enough attention and thus not be implemented.
  • I understand this change request may be rejected due to other community members thinking it's inappropriate.
  • I believe this feature would make the pack better.
  • I'm the official maintainer or original author of this mod for minecraft 1.7.10.
@Rosenlied-Iris Rosenlied-Iris added Status: Triage Issue awaiting triage. Remove once this issue is processed Type: Mod Addition labels Feb 15, 2023
@potato4444
Copy link

potato4444 commented Feb 15, 2023

This is a mod I was considering my adding but to my own installation but did not as it apparently causes rendering problems for Botania and Twilight Forest: zlainsama/SkinPort#28, zlainsama/SkinPort#9

@Rosenlied-Iris
Copy link
Author

This is a mod I was considering my adding but to my own installation but did not as it apparently causes rendering problems for Botania and Twilight Forest: zlainsama/SkinPort#28, zlainsama/SkinPort#9

Wonder how hard it would be to fix this, and whether this would be on the end of a SkinPort fork or our Botania/Twilight versions.

@vovaksenov
Copy link

Mitch said foamfix adds support for newer skins as well, and since it is under lgpl, the related code could be transferred into hodgepodge or any other appropriate mod already included in the pack

@bombcar
Copy link
Member

bombcar commented Nov 14, 2023

If someone who can reproduce the skin issue can try foam fix for 1.7.10 and confirm it fixes it, we can at least update the wiki.

@mitchej123 mitchej123 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
@mitchej123 mitchej123 added Status: Stale Automatically close this issue in 2 weeks if there are no new responses Comment to reopen labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Automatically close this issue in 2 weeks if there are no new responses Status: Triage Issue awaiting triage. Remove once this issue is processed Type: Mod Addition
Projects
None yet
Development

No branches or pull requests

5 participants