Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potion Flask not craftable with Chicken Trophy that has been placed in the world #18894

Closed
2 of 3 tasks
wlhlm opened this issue Jan 28, 2025 · 1 comment
Closed
2 of 3 tasks
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed Type: Recipe

Comments

@wlhlm
Copy link
Member

wlhlm commented Jan 28, 2025

Your GTNH Discord Username

rot13

Your Pack Version

2.7.2

Your Server

SP

Java Version

Java 21

Type of Server

None

Your Expectation

Craft Potion Flask (Flight) in MV Assembler with a Chicken Trophy and a Feather.

The Reality

Nothing happened after placing the ingredients in the machine. After some troubleshooting, I was able to craft the Potion Flask when cheating in the ingredients through NEI.

I suspect NBT is the issue here, ie. if the Trophy is placed in the world and then picked up again, it has additional data that the recipe no longer accepts. If I cheat in a trophy from NEI, place it in the world, and pick it up again, it also no longer works in the Potion Flask recipe.

Chicken trophy NEI:

/mt hand
<OpenBlocks:trophy>.withTag({entity: "Chicken"})

Chicken trophy after placing it in world and picking it up again:

/mt hand
<OpenBlocks:trophy>.withTag({cooldown: 0, entity: "Chicken"})

Your Proposal

Make the recipe more lenient to make it work with trophies with the cooldown tag.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@wlhlm wlhlm added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed Type: Recipe labels Jan 28, 2025
@StaffiX
Copy link
Contributor

StaffiX commented Jan 28, 2025

This has been fixed by GTNewHorizons/OpenBlocks#26

@StaffiX StaffiX closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed Type: Recipe
Projects
None yet
Development

No branches or pull requests

2 participants