Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transferring all of one item type should not leave one item stack on cursor if inventory is full #45

Open
1 task done
KleinGrrmpf opened this issue Jan 13, 2025 · 6 comments

Comments

@KleinGrrmpf
Copy link

Your GTNH Discord Username

@KleinGrrmpf

Feature Request

With MouseTweaks, pressing Ctrl+Shift transferred all of one item type until inventory was full, but didn't pick up any stacks onto the cursor. Here, using the Alt modifier to transfer one item type still always leaves a stack on the cursor, which has to be put back or is dropped on the floor upon closing the UI.

Final Checklist

  • I have searched the issues and haven't found a similar issue.
@Caedis
Copy link
Member

Caedis commented Jan 13, 2025

I was only able to recreate this if i had an itemstack in my cursor when activating the move all keybind

@KleinGrrmpf
Copy link
Author

Hmm... Can't recreate it anymore either, and I was doing it in the same chest with the same item type... I'll do some more testing if it comes up again

1 similar comment
@KleinGrrmpf
Copy link
Author

Hmm... Can't recreate it anymore either, and I was doing it in the same chest with the same item type... I'll do some more testing if it comes up again

@KleinGrrmpf
Copy link
Author

Something that I can say however, is that sometimes when I transfer all of one type, the stack does pop up in the cursor for one tick. It's not often, but I have seen it every once in a while. And I assume that when that happens and the inventory is full, the stack just remains in the cursor (which did happen to me once today, so it is very much still a thing)

@Caedis
Copy link
Member

Caedis commented Jan 15, 2025

The thing is i searched through the code and couldnt find any reference to stacks being put in the cursor. It all happens on the server.

@KleinGrrmpf
Copy link
Author

KleinGrrmpf commented Jan 17, 2025

https://www.youtube.com/watch?v=_IpQe54rphA

You can see the itemstack briefly pop up in the cursor at 0:18 before being correctly sent to the chest inventory. And when I move items to my own inventory, sometimes one stack stays on the cursor. All that I am doing is holding ALT and left-clicking on the itemstacks

Idk if this helps, if you want me to provide anything more, I will do what I can.
This is singleplayer.

@KleinGrrmpf KleinGrrmpf reopened this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants