Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping mod doesn't work with LWJGL3ify #182

Open
brandyyn opened this issue Oct 18, 2024 · 1 comment
Open

Ping mod doesn't work with LWJGL3ify #182

brandyyn opened this issue Oct 18, 2024 · 1 comment

Comments

@brandyyn
Copy link

there’s an issue in some mods, for example the ping mod where you press the button to bring up a radial ping menu in game to ping a block, in Java 8 it stops your camera from moving and you can select the type of ping you want, with lwjgl3ify it moves your entire camera with your mouse on screen and menu open, so you will turn away from the block you’re trying to ping and ping another block or the air etc
I was told by the maintainer that they can’t fix it and it’s an issue on lwjgl3ifys side

2024-07-13_22-52-16.2.mp4

happens with both:
https://github.com/GirafiStudios/Ping
OR
https://github.com/GTMEGA/Ping

here's the code for the mod:

public class GuiPingSelect {

public static boolean active = false;

public static long activatedAt = 0;

public static void activate() {
    Minecraft mc = Minecraft.getMinecraft();
    mc.inGameHasFocus = false;
    mc.mouseHelper.ungrabMouseCursor();
    active = true;
    activatedAt = System.nanoTime();
}

public static void deactivate() {
    Minecraft mc = Minecraft.getMinecraft();
    if (mc.currentScreen == null) {
        mc.inGameHasFocus = true;
        mc.mouseHelper.grabMouseCursor();
    }
    active = false;
}
@brandyyn
Copy link
Author

brandyyn commented Jan 9, 2025

fixed on mega ping's side
GTMEGA/Ping@e396982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant