Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic move 2 and basic attack 2 actions are not separated by a space #7

Open
GVigne opened this issue Sep 1, 2023 · 0 comments
Open

Comments

@GVigne
Copy link
Owner

GVigne commented Sep 1, 2023

Describe the bug
Since version 1.2.0, the basic attack 2 and basic move 2 glyphs are not separated by a space and are instead side by side.

How to reproduce
Simply load any card: this is an internal bug and doesn't depend on user inputs.

Expected behavior
The images and numbers should be separated by a blank space.

Version and environment
This happens on any platform, from 42916f0 onwards.

Screenshots
In version 1.2:
image
In version 1.1, and as it should be:
image

Technical explanation
Before 42916f0, items in a LineItem were placed adjacent to each other, and only images had white spaces before and after them. 42916f0 generalises this behavior by placing a space between every items in a LineItem. However, the current implementation of the default actions does not rely on a LineItem, but on a TextItem and an ImageItem (see create_card_layout from gloomhavenclass.py)

Additional context
If someone needs this bug fixed quickly, please reply to this issue and I will release a patch.
This issue will also be fixed in version 2.0, when Frosthaven formatting will be introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant