Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0711 backend workflow add mypy test #6 #8

Closed
wants to merge 2 commits into from
Closed

0711 backend workflow add mypy test #6 #8

wants to merge 2 commits into from

Conversation

yockwang
Copy link
Contributor

mypy #6

@yockwang yockwang self-assigned this Jul 10, 2023
@yockwang yockwang linked an issue Jul 10, 2023 that may be closed by this pull request
mypy #6 #6
Open
@yockwang yockwang requested a review from teds-lin July 10, 2023 16:56
@teds-lin
Copy link
Contributor

建議新增mypy.ini設定
將型別檢查限制在實際關心的code就好
通常沒有很關心 test 的部分有沒有 type hint
(將tests資料夾設為例外, 或者限制只檢查backend/magician內的py程式碼)

@teds-lin teds-lin closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teds-lin teds-lin Awaiting requested review from teds-lin

Assignees

@yockwang yockwang

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy #6
2 participants
@yockwang @teds-lin