309 fixed power prior #315
Conversation
|
@gravesti looks good. Was a bit surprised to see a vector of weights, as the fixed power prior is typically one weight for all the external data, right? (And I see that the test cases are doing this already). I guess there is no downside to doing it this way because it is more flexible and we can use it for eg IPTW weights. Seeing now that the stan templates is annoying, but still I bet this is the best approach. |
| #' ext_flag_col = "ext", | ||
| #' power_col = "power" | ||
| #' ) | ||
| borrowing_fixed_power_prior <- function(ext_flag_col, power_col) { |
There was a problem hiding this comment.
@gravesti What about some checking that power_col is [0,1] here as well? I see in STAN but maybe the error would be cryptic?
There was a problem hiding this comment.
We don't have the data here. I will add it in prepare_stan_data_inputs
Yeah, we could go for specifying a number directly: |
No description provided.