Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes in CMakeLists.txt file #342

Conversation

Anushkaagrawal22
Copy link

Added cmake_minimum_required() at the beginning of CMakeLists.txt
Keeping project() declaration

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you like to check for this in examples and check for inconsistencies? In examples we use minimum version 3.11, is there a reason to use 3.10?

@Anushkaagrawal22
Copy link
Author

The error in mac is:
Package required but not available: ‘RcppEigen’
I'll try to add this to the package.

The Ubuntu build is showing a test failure in the sparse sampling test.

And I'll change the version from 3.10 to 3.11.

@vissarion
Copy link
Member

The error in mac is: Package required but not available: ‘RcppEigen’ I'll try to add this to the package.

This is fixed, please merge with develop.

The Ubuntu build is showing a test failure in the sparse sampling test.

Yes, this is another issue.

And I'll change the version from 3.10 to 3.11.

You should select the minimum that works, this is 3.10, right? Could it be even smaller?

@Anushkaagrawal22
Copy link
Author

You should select the minimum that works, this is 3.10, right? Could it be even smaller?

I checked, and using anything lower might cause compatibility issues with some features. That's why i think we should keep it to 3.10

@Anushkaagrawal22
Copy link
Author

This is fixed, please merge with develop.

Merged

@vissarion
Copy link
Member

I cannot see any of your changes.

@Anushkaagrawal22
Copy link
Author

I cannot see any of your changes.

Merge

I have already merged my branch into develop. Please find the attached.
Can you elaborate more?

P.S - I have few doubts, can we connect on the same whenever you are available?

@vfisikop
Copy link
Contributor

You have to merge GeomScale:develop to your branch. Note that the develop branch of your fork is different than the develop branch of volesti

All the details are here: https://github.com/GeomScale/volesti/blob/develop/CONTRIBUTING.md

@Anushkaagrawal22
Copy link
Author

I have merged the changes. Kindly review and merge it.

@vissarion
Copy link
Member

Still the changes are not visible in this PR see https://github.com/GeomScale/volesti/pull/342/files

You have to merge develop to corresponding branch of this PR i.e. Anushkaagrawal22:Missing-cmake_minimum_required()-fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing cmake_minimum_required() Declaration Before Project Definition
3 participants