Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problems when running with single processor #19

Open
seanmacavaney opened this issue Jun 8, 2020 · 0 comments
Open

problems when running with single processor #19

seanmacavaney opened this issue Jun 8, 2020 · 0 comments

Comments

@seanmacavaney
Copy link
Contributor

From #18 -- it seems there are several issues when running the pipeline when only a single processor is available.

First, safe_thread_count returns 0, which causes problems downstream. https://github.com/Georgetown-IR-Lab/OpenNIR/blob/master/onir/util/concurrency.py#L11

Then, places that use util.blocking_tee and util.CtxtThread may have some race conditions.

Ideally, a solution that falls back when only one processor is detected. If not, a configuration switch somewhere could help.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanmacavaney