Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include message-simple-data in the MessageSimple height #65

Open
MartinCupela opened this issue Mar 14, 2022 · 0 comments
Open

Include message-simple-data in the MessageSimple height #65

MartinCupela opened this issue Mar 14, 2022 · 0 comments

Comments

@MartinCupela
Copy link
Collaborator

MartinCupela commented Mar 14, 2022

Problem

The str-chat__message-data str-chat__message-simple-data element (child of MessageSimple) has position:absolute and so is not counted towards the margin-bottom of the last message in the message group. That makes it more difficult to control spacing below the last message in the message group.

Proposed solution

To make it easier for the integrators to control spacing between the messages - e.g. to have equal spacing between the messages without having to calculate the height - the message data component should have position: static. That will have impact on the position of Avatar, that will be lowered down to the level of message-data. The Avatar can be positioned by adding padding or margin-bottom to its wrapper.

image

Ref to the problem:

position: absolute;

Also the data container cannot be a sibling of the message text bubble if it has position: static. Otherwise the message actions button will be pushed to the center of the screen.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant