Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Disconnection timeout during call #573

Merged
merged 3 commits into from
Oct 18, 2024
Merged

[Feature]Disconnection timeout during call #573

merged 3 commits into from
Oct 18, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Oct 14, 2024 •
edited
Loading

🎯 Goal

Provide a way to set how long a user can remain disconnected but in call (waiting to reconnect) after a network disruption.

🧪 Manual Testing Notes

  • From the login screen set the Disconnection Timeout to the desired time (in seconds)
  • Join a call
  • Disable Wifi and mobile data
  • After the set amount of time, you should be disconnected and presented with a toast regarding the error.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Oct 14, 2024
@ipavlidakis ipavlidakis self-assigned this Oct 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 14, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.42 MB 7.43 MB +1 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the feature/limit-on-disconnected-state branch from 06b829c to a7967ed Compare October 17, 2024 19:43
@ipavlidakis ipavlidakis marked this pull request as ready for review October 17, 2024 19:43
@ipavlidakis ipavlidakis requested a review from a team as a code owner October 17, 2024 19:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
113 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

martinmitrevski
martinmitrevski approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@ipavlidakis ipavlidakis merged commit 1fb40f1 into develop Oct 18, 2024
15 of 16 checks passed
@ipavlidakis ipavlidakis deleted the feature/limit-on-disconnected-state branch October 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski