[Fix]Accepting call on another device will sync state with CallViewModel #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
ipavlidakis
commented
Jan 24, 2025
| case .incoming where event.user?.id == streamVideo.user.id: | ||
| break | ||
| case let .incoming(incomingCall) | ||
| where event.callCid == callCid(from: incomingCall.id, callType: incomingCall.type) && event.user?.id == streamVideo.user |
There was a problem hiding this comment.
I simply aligned the implementation with how we are doing it on reject
martinmitrevski
approved these changes
Jan 24, 2025
|
ipavlidakis
deleted the
fix/accepting-call-on-another-device-dismisses-updates-callviewmodel-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-673/[support]user-accepts-ringing-call-in-one-device-in-app-incoming
📝 Summary
When a user accepts a ringing call from one device, on all their other devices correctly dismiss CallKit push notification but they do not update CallViewModel's internal state, resulting in the in-app incoming call to remain on screen.
🧪 Manual Testing Notes
☑️ Contributor Checklist