Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable Bedrock Skins #191

Open
Kruize1 opened this issue Aug 14, 2021 · 9 comments
Open

Option to disable Bedrock Skins #191

Kruize1 opened this issue Aug 14, 2021 · 9 comments
Labels
enhancement New feature or request

Comments

@Kruize1
Copy link

Kruize1 commented Aug 14, 2021

I mainly ask for this option as a way to possibly improve performance.

Geyser + Floodgate seem to take up about 1 Gig of RAM, but I think maybe disabling bedrock skins will allow for slightly better performance, as they wont need to connect to the Skin Uploader?

@Camotoy
Copy link
Member

Camotoy commented Aug 14, 2021

While that is a fine request, we'd rather just decrease the memory consumption (or at least find out what's really taking up all that RAM instead of guessing). Are you able to send over a heap dump instead? https://www.baeldung.com/java-heap-dump-capture

@Kruize1
Copy link
Author

Kruize1 commented Aug 14, 2021

I can send the heap dump, but would attaching it here be okay and the preferred method? Or how should I send it to you?

@Camotoy
Copy link
Member

Camotoy commented Aug 14, 2021

If you are able, you are free to send it here.

@Kruize1
Copy link
Author

Kruize1 commented Aug 14, 2021

It doesn't seem to work, can I send the file to you via Discord?

@Camotoy
Copy link
Member

Camotoy commented Aug 14, 2021

Yes.

@Camotoy
Copy link
Member

Camotoy commented Aug 14, 2021

Honestly it seems like Dynmap is the biggest plugin affecting your RAM. Try removing that?

@Kruize1
Copy link
Author

Kruize1 commented Aug 14, 2021

I already disabled Dynmap, but I still had memory issues unfortunately.

When I start my server without Geyser + Floodgate my memory usage starting out is around 2.7/4 Gigs

However, I just tried with both enabled and RAM usage starts fairly high:
image

Is 1 Gig of memory usage the expected amount? Or what should the memory usage roughly be?

@Tim203
Copy link
Member

Tim203 commented Sep 4, 2021

If this is purely for improving performance then I think that closing this issue is the best thing to do as it barely affects performance / ram usage.
If you're seriously interested in having an option to disable this because you don't want anyone to see (converted) Bedrock skins, I'll keep it open until we've looked into adding more config options.

@Tim203 Tim203 added the needs more info Further information is requested label Sep 4, 2021
@Kruize1
Copy link
Author

Kruize1 commented Sep 8, 2021

Yes, I would like to have that option.

@Tim203 Tim203 changed the title Request - Option to disable Bedrock Skins Option to disable Bedrock Skins Nov 4, 2022
@Tim203 Tim203 added enhancement New feature or request and removed needs more info Further information is requested labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants