-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension v2.3.0 becomes unresponsive #152
Comments
What's concerning here is that the slowdown is actually being caused by the new syntax selector parser based on Atom. This was actually proposed for VS Code in microsoft/vscode-textmate#52 and I was investigating having this parser work in WASM over at peggyjs/peggy#222 but I cannot promise anything other than reverting that huge upgrade in scope power. This is a significant setback and I'm disappointed to see it happen :( |
Okay actually its the parser as written by the MS Atom team that is slow on low-end CPUs in anything other than WASM. |
Added caching instead of the Rust thing, it worked! Fix soon:tm: |
Thank you! |
Actually do you have NPM on your computer? You could:
And see if the CPU issue is resolved? |
Did as you asked; for now it looks fine. |
Update to 2.3.1 to resolve this! |
I will be posting a postmortem for the performance issues from my library in #142. |
Here is the cpu profile:
exthost-8a6262.cpuprofile.zip
This did not occur until a few days ago, so I suspect a recent change, which could be v2.3.0.
The text was updated successfully, but these errors were encountered: