Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newest version of c3/d3 #98

Open
scooterlord opened this issue Jul 1, 2019 · 5 comments
Open

Update to newest version of c3/d3 #98

scooterlord opened this issue Jul 1, 2019 · 5 comments

Comments

@scooterlord
Copy link

Hello,

I've seen it was an issue in the past, but is there a way to update to the latest d3/c3 libraries?

Even better, would it be able for us to upgrade on our own on-demand?

Thanks for your time!

@maxwondercorn
Copy link
Collaborator

I can bump the versions and will try to do it this weekend. Since the ember-c3 now uses ember-auto-import that might now be possible.

It might be as easy as having the addon install them into the app vs in the addon. ember-auto-import should be able to pick it up for the addon.

@scooterlord
Copy link
Author

Great news! Looking forward to any updates!

@maxwondercorn
Copy link
Collaborator

maxwondercorn commented Jul 11, 2019

I have updated c3/d3 to the latest versions but still need to publish to NPM. I need to look at the changes required to allow end user updates to c3/d3. I'm leaving this issue open until that work is completed

@scooterlord The updated ember-c3 has been published

@maxwondercorn
Copy link
Collaborator

@scooterlord I updated the C3/D3 latest versions and Ember 3.12. I looked into installing C3 & D3 in the application via the blueprint hooks. This would allow maintaining versions in the app versus the addon.

ember-auto-import doesn't allow this. It generates an error if the imports are found in the app's devDependencies. I think it should allow whitelisting of packages to allow imports. I will raise a feature request in the repo and leave this issue open

@scooterlord
Copy link
Author

@maxwondercorn thanks for the update! Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants