Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config loading #15

Open
clone1018 opened this issue Mar 2, 2023 · 5 comments
Open

Improve config loading #15

clone1018 opened this issue Mar 2, 2023 · 5 comments
Assignees
@Shulammite-Aso
Labels
good first issue Good for newcomers

Comments

@clone1018
Copy link
Member

Currently the main.go file is a complete cluster of config loading code. We should figure out how to refactor / optimize this.
@clone1018 clone1018 added the good first issue Good for newcomers label Mar 2, 2023
@Shulammite-Aso
Copy link

Hi @clone1018 I see what you're talking about here, and I want to work on it.

We've met on the Golang workspace on slack. I talked about contributing.

@clone1018
Copy link
Member Author

Hey! Good to see you here, this is a good issue to get started with. I did recently add some new sections to the readme that walk through building, configuring, and running a sample environment.

https://github.com/Glimesh/waveguide#building

Please let me know if you have any questions!

@Shulammite-Aso
Copy link

I will.

@nassah221 nassah221 mentioned this issue Mar 10, 2023
Merged
@nassah221
Copy link
Collaborator

Sorry I didn't see this thread until I had already opened #18

@clone1018
Copy link
Member Author

Definite improvements have been made & merged in #18!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shulammite-Aso Shulammite-Aso

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clone1018 @Shulammite-Aso @nassah221