GA replaces random() unconditionally

[jeffdaily]

In Makefile.am, we see

##############################################################################
# compat
#
# Although the compat directory houses replacements for missing or erroneous
# standard C functions and such sources are conditionally compiled based on
# results from configure tests, without the "random" implementation the
# m4-generated tests always fail for scatter and copy_patch.
libga_la_SOURCES += compat/random.c

First of all, I have no idea if we even still need to use the autotool functionality of LIBOBJS. See https://www.gnu.org/software/automake/manual/html_node/LIBOBJS.html for details.

The main issue here is that random.c is unconditionally compiled. Worse yet, it appears that if we don't override the system random() and srandom() we somehow break some tests. Our compat/random.c appears to be a permissively-licensed copy of BSD's random() from 1983...?

@edoapra, would it be possible to evaluate how this replacing of system provided random() affects NWChem? I would love to remove from GA such strange hacks. A related issue is that GA provides a "drand" implementation for fortran, unconditionally. So this would replace perhaps any drand() functions provided by ifort, for example. Our drand() is a wrapper around the C random() -- the same random() we already replace...

[edoapra]

Jeff,
Even though drand() is still used in a few places in NWChem, I do not see any reason for keeping it around in GA land. We have already a wrapper for C random() that can be used

[edoapra]

I have just removed any mention of drand() from the NWChem dev repository