-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP4 conversion speed improvement opportunity #329
Comments
I canceled the job on master (before #311) because I wanted to work on something else.
Pretty crazy for a 160 seconds pcap... |
Did some profiling with snakeviz today. It was clear where the bulk of our time was spent: Reading about with
with
|
The previous comment had nothing to do with the investigation needed for this issue. I opened a PR with the same content #349 and I will leave this issue open. |
While working on #311 I realized that if the file I/O was going nowhere (output file set to an invalid path that didn't exist for example), then conversion would happen dramatically faster but still be long enough to be credible that it would happen (2x capture duration for example). Maybe there's something wrong in our use of file i/o that I would like to investigate later.
To reproduce, use the PDU-based pcap I used to test the
pcap-fix
branch and convert it to mp4.The text was updated successfully, but these errors were encountered: