From 00065212b23a664016be80a66d1d8df31c3c7851 Mon Sep 17 00:00:00 2001 From: Jason Robbins Date: Wed, 15 Jan 2025 18:29:53 +0000 Subject: [PATCH] Add new enterprise reviewer. (#4700) --- internals/approval_defs.py | 1 + internals/reminders_test.py | 19 ++++++++++++------- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/internals/approval_defs.py b/internals/approval_defs.py index 5d0c30f64b6b..a7e420934959 100644 --- a/internals/approval_defs.py +++ b/internals/approval_defs.py @@ -47,6 +47,7 @@ 'omole@google.com', 'nsamarakkody@google.com', 'pastarmovj@google.com', + 'aaudi@google.com', ] DEBUGGABILITY_APPROVERS = IN_NDB TESTING_APPROVERS = [ diff --git a/internals/reminders_test.py b/internals/reminders_test.py index 1724a04091e5..a03088ed8a26 100644 --- a/internals/reminders_test.py +++ b/internals/reminders_test.py @@ -506,8 +506,9 @@ def test_get_template_data__one_due_unassigned(self, mock_now_utc): with test_app.app_context(): actual = self.handler.get_template_data() - expected_message = (f'6 email(s) sent or logged.\n' + expected_message = (f'7 email(s) sent or logged.\n' 'Recipients:\n' + 'aaudi@google.com\n' 'angelaweber@google.com\n' 'davidayad@google.com\n' 'mhoste@google.com\n' @@ -549,8 +550,9 @@ def test_get_template_data__initial_overdue_unassigned(self, mock_now_utc): with test_app.app_context(): actual = self.handler.get_template_data() - expected_message = (f'6 email(s) sent or logged.\n' + expected_message = (f'7 email(s) sent or logged.\n' 'Recipients:\n' + 'aaudi@google.com\n' 'angelaweber@google.com\n' 'davidayad@google.com\n' 'mhoste@google.com\n' @@ -573,9 +575,10 @@ def test_get_template_data__initial_overdue_assigned(self, mock_now_utc): with test_app.app_context(): actual = self.handler.get_template_data() - expected_message = (f'7 email(s) sent or logged.\n' + expected_message = (f'8 email(s) sent or logged.\n' 'Recipients:\n' 'a_assignee@example.com\n' + 'aaudi@google.com\n' 'angelaweber@google.com\n' 'davidayad@google.com\n' 'mhoste@google.com\n' @@ -596,8 +599,9 @@ def test_get_template_data__due_resolve_unassigned(self, mock_now_utc): with test_app.app_context(): actual = self.handler.get_template_data() - expected_message = (f'6 email(s) sent or logged.\n' + expected_message = (f'7 email(s) sent or logged.\n' 'Recipients:\n' + 'aaudi@google.com\n' 'angelaweber@google.com\n' 'davidayad@google.com\n' 'mhoste@google.com\n' @@ -619,8 +623,9 @@ def test_get_template_data__resolve_overdue_unassigned(self, mock_now_utc): with test_app.app_context(): actual = self.handler.get_template_data() - expected_message = (f'6 email(s) sent or logged.\n' + expected_message = (f'7 email(s) sent or logged.\n' 'Recipients:\n' + 'aaudi@google.com\n' 'angelaweber@google.com\n' 'davidayad@google.com\n' 'mhoste@google.com\n' @@ -684,7 +689,7 @@ def test_build_gate_email_tasks__initial_overdue(self): {self.feature_1.key.integer_id(): self.feature_1}, True, True) - self.assertEqual(8, len(actual)) + self.assertEqual(9, len(actual)) task = actual[0] self.assertEqual('a_assignee@example.com', task['to']) self.assertEqual('ESCALATED: Review due for: feature one', task['subject']) @@ -722,7 +727,7 @@ def test_build_gate_email_tasks__resolution_overdue(self): {self.feature_1.key.integer_id(): self.feature_1}, True, False) - self.assertEqual(8, len(actual)) + self.assertEqual(9, len(actual)) task = actual[0] self.assertEqual('a_assignee@example.com', task['to']) self.assertEqual('ESCALATED: Review due for: feature one', task['subject'])