From 1dfaaf3b2280a9eaacee6e066de006c8784cfaf5 Mon Sep 17 00:00:00 2001 From: Jason Robbins Date: Thu, 9 Nov 2023 12:49:22 -0800 Subject: [PATCH] Move debuggability reviewers into NDB. (#3485) --- internals/approval_defs.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/internals/approval_defs.py b/internals/approval_defs.py index 02f56aaab219..e9b7e24764e1 100644 --- a/internals/approval_defs.py +++ b/internals/approval_defs.py @@ -44,13 +44,7 @@ 'davidayad@google.com', 'bheenan@google.com', ] -DEBUGGABILITY_APPROVERS = [ - 'bmeurer@google.com', - 'danilsomsikov@google.com', - 'yangguo@google.com', - 'changhaohan@google.com', - 'pfaffe@google.com', -] +DEBUGGABILITY_APPROVERS = IN_NDB TESTING_APPROVERS = [ 'sadapala@google.com', 'santhoshkumarm@google.com', @@ -218,7 +212,7 @@ def auto_assign_reviewer(gate): if response.status_code != 200: logging.error('Could not fetch %r', url) logging.error('Got response %s', repr(response)[:settings.MAX_LOG_LINE]) - raise ValueError('Could not fetch oncall') + return try: logging.info(