-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⛱️ PSI Error-Handling #9137
Comments
I can audit https://www.tensorflow.org/ directly with LR via the demo app. It takes 80+ seconds. PSI has a 60 second timeout, so of course it doesn't make the cut. But the error I get is just grr |
PSI doubles codes in error messages. ex: |
@connorjclark and I found that the above comment is not reproducible 🙂 |
We're happy with how we present errors in PSI today. and this is old ui. |
Summary
PSI Errors are not helpful to the users 😭, so let's make em' more useful!
Issues Where Errors are Just Straight Up Not Having A Good Time
PSI g/ threads:
Errors within audits that are confusing:
Other Opportunities
What Do Errors Look Like?
Runtime Errors != []
![image](https://user-images.githubusercontent.com/6392995/59071502-c76df700-8873-11e9-8eb4-f936abe013fe.png)
1 Form Factor errored, but the other didn't
![image](https://user-images.githubusercontent.com/6392995/59071574-1e73cc00-8874-11e9-8b75-c2dd56f1ee42.png)
Infamous Backend Error
![image](https://user-images.githubusercontent.com/6392995/59071584-2c295180-8874-11e9-899b-7092d940f1f4.png)
Recommendations
In Progress
The text was updated successfully, but these errors were encountered: