Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛱️ PSI Error-Handling #9137

Closed
exterkamp opened this issue Jun 6, 2019 · 4 comments
Closed

⛱️ PSI Error-Handling #9137

exterkamp opened this issue Jun 6, 2019 · 4 comments
Assignees
Labels
needs-priority PSI/LR PageSpeed Insights and Lightrider

Comments

@exterkamp
Copy link
Member

exterkamp commented Jun 6, 2019

Summary

PSI Errors are not helpful to the users 😭, so let's make em' more useful!

Issues Where Errors are Just Straight Up Not Having A Good Time

PSI g/ threads:

Errors within audits that are confusing:

Other Opportunities

What Do Errors Look Like?

  • Runtime Errors != []
    image

  • 1 Form Factor errored, but the other didn't
    image

  • Infamous Backend Error
    image

Recommendations

In Progress

  • Better Docs on using PSI in general to avoid common pitfalls
  • PSI FAQ for v5+ known errors + a reminder to check FAQ before making an issue
@connorjclark
Copy link
Collaborator

I can audit https://www.tensorflow.org/ directly with LR via the demo app. It takes 80+ seconds.

PSI has a 60 second timeout, so of course it doesn't make the cut. But the error I get is just Backend Error.

grr

@connorjclark
Copy link
Collaborator

PSI doubles codes in error messages. ex: (NO_FCP) (NO_FCP)

@paulirish paulirish added PSI/LR PageSpeed Insights and Lightrider and removed pagespeed-insights labels Jul 23, 2019
@jazyan
Copy link
Collaborator

jazyan commented Feb 25, 2020

@connorjclark and I found that the above comment is not reproducible 🙂

@connorjclark
Copy link
Collaborator

We're happy with how we present errors in PSI today. and this is old ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-priority PSI/LR PageSpeed Insights and Lightrider
Projects
None yet
Development

No branches or pull requests

5 participants